feat: Add FDv2 Streaming Synchronizer #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd-fdv2-data-source-interfaces
…unchdarkly/java-core into rlamb/add-fdv2-data-source-interfaces
…ming-synchronizer
kinyoklion
changed the base branch from
main
to
rlamb/add-fdv2-data-source-interfaces
Base automatically changed from
rlamb/add-fdv2-data-source-interfaces
to
main
January 15, 2026 23:31
kinyoklion
commented
Jan 16, 2026
| case NONE: | ||
| break; | ||
| case INTERNAL_ERROR: { | ||
| FDv2ProtocolHandler.FDv2ActionInternalError internalErrorAction = (FDv2ProtocolHandler.FDv2ActionInternalError) res; |
Member
Author
There was a problem hiding this comment.
Gap identified working on streaming.
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/StreamingSynchronizerImpl.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces a streaming data path and tightens error/shutdown semantics.
StreamingSynchronizerImplmaintains an SSE connection viaEventSource, lazily starts onnext(), queuesCHANGE_SET/status results, restarts onGOODBYE, and maps HTTP/network/serialization/internal errors to appropriateINTERRUPTEDvsTERMINAL_ERROR. Injects selector (version/state) and optionalfilterquery params per request; proper shutdown viaclose().PollingSynchronizerImplcancels the scheduled task and completesshutdownFutureonTERMINAL_ERROR(avoids re-queuing), andnext()now races queued results vs shutdown.PollingBasemapsINTERNAL_ERRORsubtypes (MISSING_PAYLOAD/JSON_ERROR) toINVALID_DATA.Initializer.run()single-use intent; updatesSynchronizerstate diagram (e.g.,GOODBYEreturns toRUNNING) and guidance on callingnext()after terminal states.StreamingSynchronizerImplTestcovering changesets, recoverable/non-recoverable HTTP errors, network/invalid data, reconnection, selector/filter query params, heartbeats, goodbye, and shutdown; extends polling tests for internal error kind mapping and continued polling behavior.Written by Cursor Bugbot for commit 9c1c4c4. This will update automatically on new commits. Configure here.