Skip to content

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Jan 15, 2026

Note

Introduces dynamic query parameter support for the SSE client.

  • Adds Client#query_params callback to compute query params before each connection/reconnection; merges with existing URI params (dynamic values can override), URL-encodes values, and safely handles nil/empty/non-Hash returns or exceptions
  • Connection now uses build_uri_with_query_params to construct the request URI
  • Comprehensive specs cover initial connection, reconnection updates, merging/overriding, error/nil handling, URL encoding, and multiple params
  • RuboCop config: switch to plugins and rename Naming/PredicateName to Naming/PredicatePrefix

Written by Cursor Bugbot for commit f5cd3fc. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey requested a review from a team as a code owner January 15, 2026 18:34
@jsonbailey jsonbailey merged commit e6c76bf into main Jan 15, 2026
10 checks passed
@jsonbailey jsonbailey deleted the jb/sdk-1546/allow-header-updates branch January 15, 2026 19:39
jsonbailey pushed a commit that referenced this pull request Jan 15, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.4.0](2.3.0...2.4.0)
(2026-01-15)


### Features

* Support dynamic query parameter on reconnect
([#74](#74))
([e6c76bf](e6c76bf))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Publishes v2.4.0 with a small feature addition.
> 
> - Adds release notes for supporting dynamic query parameter on
reconnect in `CHANGELOG.md`
> - Bumps version from `2.3.0` to `2.4.0` in
`.release-please-manifest.json` and `lib/ld-eventsource/version.rb`
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
a54833f. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants