chore: Add FDv2 compatible data source for testing #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonbailey
commented
Jan 8, 2026
| until @closed | ||
| begin | ||
| # stop() will push nil to the queue to wake us up when shutting down | ||
| update = @update_queue.pop |
Contributor
Author
There was a problem hiding this comment.
@keelerm84 Ruby doesn't have a pop with timeout like we do in Python. The stop method will push nil into the queue to stop it from blocking so I'm not sure it is needed but I wanted to call it out.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
keelerm84
reviewed
Jan 8, 2026
Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
keelerm84
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces an FDv2-ready testing data source and aligns APIs/constants.
integrations/test_data_v2:TestDataV2withFlagBuilderV2for building flags/rules/targets anduse_preconfigured_segment; emits updates to all attached instancesimpl/integrations/test_data/test_data_source_v2: implements bothInitializerandSynchronizerto serve initial data and stream change sets (flags/segments)data_system/config: fixdata_store_modenamespace toInterfaces::DataSystem::DataStoreModeand wire builders (daemon/persistent store helpers)impl/data_store/store: broadcastFlagChangeobjects instead of raw keysspec/impl/data_system/fdv2_datasystem_spec.rb) and TestDataV2 unit tests (spec/integrations/test_data_v2_spec.rb)Written by Cursor Bugbot for commit e67b715. This will update automatically on new commits. Configure here.