Skip to content

Added missing public key exception #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iljoja wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added missing public key exception #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fdceb2
Update AuthenticatorData.php
iljoja Jan 20, 2026
bada679
Update WebAuthnException.php
iljoja Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Attestation/AuthenticatorData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,10 @@ private function _readCredentialPublicKey($binary, $offset, &$endOffset) {
*/
private function _readCredentialPublicKeyEDDSA(&$credPKey, $enc) {
$credPKey->crv = $enc[self::$_COSE_CRV];

if (!isset($enc[self::$_COSE_X])) {
throw new WebAuthnException('public key missing', WebAuthnException::MISSING_PUBLIC_KEY);
}
$credPKey->x = $enc[self::$_COSE_X] instanceof ByteBuffer ? $enc[self::$_COSE_X]->getBinaryString() : null;
unset ($enc);

Expand Down
1 change: 1 addition & 0 deletions src/WebAuthnException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class WebAuthnException extends \Exception {
const BYTEBUFFER = 14;
const CBOR = 15;
const ANDROID_NOT_TRUSTED = 16;
const MISSING_PUBLIC_KEY = 17;

public function __construct($message = "", $code = 0, $previous = null) {
parent::__construct($message, $code, $previous);
Expand Down