Adding standard typing support #426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type hints when necessary Unused loop variable in mds_rem replaced with _ to avoid warnings Moved import struct to the top of the file (was previously after the docstring)
Add type hints when necessary Add imports from typing IV is not a constant, so it was rename into iv (including in common.py) Bound i in CBC.update Raise an error is the mode is not implemented (everything except CBC) according to this issue: libkeepass#155
Add type hints when necessary Add imports from typing In DynamicDict desambigus l to item_key or items_list In Adapter classes rename data to obj and con to context to fit the parent class In compute_key_composite, use isinstance on keyfile instead of hasattr(keyfile, "read") and raise additionnal errors for "Meta/Version" There is still a lot of Any, this file should be updated when additionnal information are available.
Add type hints when necessary
Add type hints when necessary Add extra verification for nested gets Element.getchildren() is deprecated, use list(Element) instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I'm proposing some typing support for the package.
Running pyright in standard mode leave no more errors.
I tried to change the execution as little as possible, but I had to fix some issues.
The test suite still works 100% after the edits, so I hope nothing broke silently 😅
I'm still very new to the open source process
Have a nice day ✨