Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 8, 2025

Plan: Package lni into react-native-lni for npm distribution

  • Explore repository structure and understand current setup
  • Rename package from lni_react_native to react-native-lni (following React Native naming conventions)
    • Update package.json name field
    • Update package.json description and workspace references
    • Update references in README.md
    • Update references in example app (package.json and imports)
    • Update tsconfig.json path mappings
    • Update main readme.md with new package name and npm installation instructions
  • Ensure package is properly configured for npm publication
    • Verify files array in package.json (already correctly configured)
    • Verify publishConfig in package.json (already correctly configured)
    • Add .npmignore to exclude unnecessary files
    • Create PUBLISHING.md with comprehensive publishing guide
    • Update yarn.lock with new workspace names
  • Run security checks
    • Check dependencies for vulnerabilities (none found)
    • Run CodeQL security scan (no issues found)
  • Final validation and documentation review
    • Enhanced README with comprehensive installation guide
    • Added usage examples for all supported node types
    • Documented prerequisites and TypeScript support
    • Address code review feedback
    • Clarify directory vs package naming in documentation
  • Add Expo compatibility documentation
    • Clarify Expo Go is not supported (native code)
    • Document Expo development builds support
    • Add setup instructions for Expo with New Architecture
Original prompt

create a way to package up lni into a react-native-lni that can be installed on react native via npm


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 4 commits December 8, 2025 01:44
Co-authored-by: ntheile <1273575+ntheile@users.noreply.github.com>
Co-authored-by: ntheile <1273575+ntheile@users.noreply.github.com>
Co-authored-by: ntheile <1273575+ntheile@users.noreply.github.com>
Co-authored-by: ntheile <1273575+ntheile@users.noreply.github.com>
Copilot AI changed the title [WIP] Create packaging for lni as react-native-lni Package lni as react-native-lni for npm distribution Dec 8, 2025
Copilot AI requested a review from ntheile December 8, 2025 02:27
@ntheile
Copy link
Contributor

ntheile commented Dec 9, 2025

@copilot would this work in expo?

Co-authored-by: ntheile <1273575+ntheile@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 9, 2025

@copilot would this work in expo?

Yes, but with Expo development builds only, not Expo Go.

This package contains native Rust code and requires React Native's New Architecture, so it won't work with Expo Go. However, it works with Expo projects using custom development builds.

I've added Expo setup instructions to the README (commit 81f66f0) including:

  • How to create a development build with npx expo run:ios/android
  • Configuring New Architecture via expo-build-properties plugin
  • Using EAS Build for production builds

The key steps are: install with npx expo install react-native-lni, configure New Architecture in app.json, and create a development build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants