chore: rust dockerfile #80
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tankyleo! This PR has been waiting for your review. |
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Thanks ! can you make this one commit / remove the merge commit in the current PR ?
| # Copy workspace files | ||
| COPY Cargo.toml Cargo.lock ./ | ||
| COPY rustfmt.toml ./ | ||
|
|
||
| # Copy all workspace members | ||
| COPY server ./server | ||
| COPY api ./api | ||
| COPY impls ./impls | ||
| COPY auth-impls ./auth-impls |
There was a problem hiding this comment.
Not familiar with Docker, looked elsewhere sounds like we could replace all these lines with just COPY . . ?
There was a problem hiding this comment.
If we do COPY . . it would need to have a .dockerignore file with things like target/** and similar, otherwise it would unnecessarily copy compile stuff and make the build process take longer.
Let me know what you prefer.
rust/Dockerfile
Outdated
| ca-certificates \ | ||
| libssl3 \ |
There was a problem hiding this comment.
Wasn't aware of these dependencies are you sure these are needed ?
There was a problem hiding this comment.
Likely yes (cf. #77), though IIRC I had to also install libssl-dev and pkg-config, too (cf. https://docs.rs/openssl/latest/openssl/#automatic).
There was a problem hiding this comment.
without libssl3 I get:
error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory
when trying to run the image
There was a problem hiding this comment.
ca-certificate seems not needed, I'll remove it, thanks.
rust/Dockerfile
Outdated
| COPY --from=builder /build/target/release/vss-server /app/vss-server | ||
|
|
||
| # Copy default configuration file | ||
| #COPY server/vss-server-config.toml /app/vss-server-config.toml |
There was a problem hiding this comment.
For now this step is mandatory, so let's not comment it out.
There was a problem hiding this comment.
We are using an external vss-server-config.toml on our k8s setup, but I guess even if this is included we can still mount and overwrite it, so I'll un-comment it here, thanks.
4 participants
fixes #74