-
Notifications
You must be signed in to change notification settings - Fork 103
Added missing code samples #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdded 10 new code-sample blocks to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cdbdf73 to
86c1e11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.code-samples.meilisearch.yaml:
- Around line 823-829: The embedder string in the search example
(search_parameter_guide_hybrid_1) is a typo: change the embedder value passed to
client.index('books').search in the "hybrid" block from 'openapi' to 'openai' so
it matches the other examples and the actual embedding provider name.
86c1e11 to
3ac0fec
Compare
|
@Strift this is ready for review |
Pull Request
What does this PR do?
Some code samples were missing, adding these makes it easy to follow the guide with the Python SDK
PR checklist
Please check if your PR fulfills the following requirements:
I did not use AI
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.