[Quality Management] - "Item Filter"; Text[400] to be replaced with Blob. Length of text variables can be unlimited. #5900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated "Condition Filter" and "Item Attribute Filter" fields in the "Qlty. Inspection Gen. Rules" page to use dedicated text variables for better clarity and maintainability. - Implemented OnValidate triggers for both filters to ensure proper setting and modification of the record. - Refactored code in various wizards (Prod. Gen. Rule, Rec. Gen. Rule, Whse. Gen. Rule) to utilize new methods for setting and getting condition filters. - Updated tests to reflect changes in the way condition filters are set, ensuring all relevant tests are passing with the new implementation. - Improved overall code readability and maintainability by replacing direct field access with method calls for setting filters.
…ilter_Text_with_BLOB
…ilter_Text_with_BLOB
…lty. Prod. Gen. Rule Wizard
…vent duplicate entries
… with flexible alternatives
…ilter_Text_with_BLOB
attilatoury
reviewed
Jan 9, 2026
src/Apps/W1/Quality Management/test/src/QltyTestsFilterHelpers.Codeunit.al
Outdated
Show resolved
Hide resolved
attilatoury
previously approved these changes
Jan 9, 2026
...ps/W1/Quality Management/app/src/Configuration/GenerationRule/QltyInspectionGenRule.Table.al
Show resolved
Hide resolved
- Implemented LastWriteTime() method in DotnetSFTPFile Codeunit to retrieve the last write time of files. - Updated ISFTPFile interface to include LastWriteTime() procedure. - Enhanced SFTPClientImplementation Codeunit to populate Last Write Time in file list. - Added Last Write Time field to SFTP Folder Content Page and Table for better visibility. - Modified Mock SFTP Client and Mock SFTP File to support Last Write Time initialization and retrieval. - Introduced new tests in MCPConfigTest Codeunit to validate missing object warnings and recommended actions. - Updated Test Input Management Codeunit to read metadata from YAML files, including language and group name. - Cleaned up ruleset.json by removing obsolete rule AL0897.
…ItemFilter method
…ilter_Text_with_BLOB
…ilter_Text_with_BLOB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced Item Filter Text[400] with BLOB
Same changes done for Condition Filter and Attribute Filter
Work Item(s)
Fixes AB#610919