Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/Microsoft.OpenApi.Hidi/OpenApiService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ private static async Task<ReadResult> ParseOpenApiAsync(string openApiFile, bool
logger.LogTrace("{Timestamp}ms: Completed parsing.", stopwatch.ElapsedMilliseconds);

LogErrors(logger, result);
LogWarnings(logger, result);
stopwatch.Stop();
}

Expand Down Expand Up @@ -652,7 +653,7 @@ private static string GetInputPathExtension(string? openapi = null, string? csdl
private static void LogErrors(ILogger logger, ReadResult result)
{
var context = result.Diagnostic;
if (context is not null && context.Errors.Count != 0)
if (context is { Errors.Count: > 0 })
{
using (logger.BeginScope("Detected errors"))
{
Expand All @@ -664,6 +665,21 @@ private static void LogErrors(ILogger logger, ReadResult result)
}
}

private static void LogWarnings(ILogger logger, ReadResult result)
{
var context = result.Diagnostic;
if (context is { Warnings.Count: > 0 })
{
using (logger.BeginScope("Detected warnings"))
{
foreach (var warning in context.Warnings)
{
logger.LogWarning("Detected warning during parsing: {Warning}", warning.ToString());
}
}
}
}

internal static void WriteTreeDocumentAsMarkdown(string openapiUrl, OpenApiDocument document, StreamWriter writer)
{
var rootNode = OpenApiUrlTreeNode.Create(document, "main");
Expand Down
Loading