-
Notifications
You must be signed in to change notification settings - Fork 28
Update code to support node-16 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@Mmdixon can we get your review on this and build binaries? Thanks! |
|
any updates on this? @Mmdixon |
|
@acoroleu-tempus Looks like the build failed because some of the dependencies are getting old and no longer hosted on the build servers (e.g. .NET core 2.1), I'll fix the build then get integration running again for this PR. |
|
@Mmdixon any progress here? |
|
@Mmdixon we'd like to upgrade our code to node16, this dependency is blocking us from doing so. Have you got time to review this PR? Thanks for your time |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Mmdixon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should drop the package-lock.json changes.
|
the package-lock.json changes are needed since node 16 updated the schema for this file. which specific changes should I drop? @Mmdixon |
|
@Mmdixon any update on this? Thanks |
No description provided.