Skip to content

Fix crash when HttpResponseDecoder receives non-JSON response #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanselip wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix crash when HttpResponseDecoder receives non-JSON response #1405

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
374a971
Fix crash when HttpResponseDecoder receives non-JSON response
Jan 23, 2026
ca99f1c
Address PR #1405 review: use parse with exceptions disabled
Jan 28, 2026
f88a641
Use iterators directly in parse() to avoid copying body
Jan 28, 2026
54de017
Remove unnecessary inner scope block
Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 60 additions & 50 deletions lib/http/HttpResponseDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,72 +169,82 @@ namespace MAT_NS_BEGIN {
{
#ifdef HAVE_MAT_JSONHPP
// TODO: [MG] - parse HTTP response without json.hpp library
nlohmann::json responseBody;
try
auto bodyBegin = response.GetBody().begin();
auto bodyEnd = response.GetBody().end();

// Handle empty body
if (bodyBegin == bodyEnd)
{
LOG_ERROR("HTTP response: body is empty, skipping processing");
return;
}

// Parse JSON with exceptions disabled (pass iterators directly to avoid copy)
nlohmann::json responseBody = nlohmann::json::parse(bodyBegin, bodyEnd, nullptr, false);

// Check if parsing failed (returns discarded value for invalid JSON)
if (responseBody.is_discarded())
{
LOG_ERROR("HTTP response: body is not valid JSON, skipping processing");
return;
}

int accepted = 0;
auto acc = responseBody.find("acc");
if (responseBody.end() != acc)
{
std::string body(response.GetBody().begin(), response.GetBody().end());
responseBody = nlohmann::json::parse(body.c_str());
int accepted = 0;
auto acc = responseBody.find("acc");
if (responseBody.end() != acc)
if (acc.value().is_number())
{
if (acc.value().is_number())
{
accepted = acc.value().get<int>();
}
accepted = acc.value().get<int>();
}
}

int rejected = 0;
auto rej = responseBody.find("rej");
if (responseBody.end() != rej)
int rejected = 0;
auto rej = responseBody.find("rej");
if (responseBody.end() != rej)
{
if (rej.value().is_number())
{
if (rej.value().is_number())
{
rejected = rej.value().get<int>();
}
rejected = rej.value().get<int>();
}
}

auto efi = responseBody.find("efi");
if (responseBody.end() != efi)
auto efi = responseBody.find("efi");
if (responseBody.end() != efi)
{
for (auto it = responseBody["efi"].begin(); it != responseBody["efi"].end(); ++it)
{
for (auto it = responseBody["efi"].begin(); it != responseBody["efi"].end(); ++it)
std::string efiKey(it.key());
nlohmann::json val = it.value();
if (val.is_array())
{
std::string efiKey(it.key());
nlohmann::json val = it.value();
if (val.is_array())
{
//std::vector<int> failureVector = val.get<std::vector<int>>();
// eventsRejected(ctx); with only the ids in the vector above
}
if (val.is_string())
//std::vector<int> failureVector = val.get<std::vector<int>>();
// eventsRejected(ctx); with only the ids in the vector above
}
if (val.is_string())
{
if ("all" == val.get<std::string>())
{
if ("all" == val.get<std::string>())
{
result = Rejected;
}
result = Rejected;
}
}
}
}

auto ticket = responseBody.find("TokenCrackingFailure");
if (responseBody.end() != ticket)
{
DebugEvent evt;
evt.type = DebugEventType::EVT_TICKET_EXPIRED;
DispatchEvent(evt);
}

if (result != Rejected)
{
LOG_TRACE("HTTP response: accepted=%d rejected=%d", accepted, rejected);
} else
{
LOG_TRACE("HTTP response: all rejected");
}
auto ticket = responseBody.find("TokenCrackingFailure");
if (responseBody.end() != ticket)
{
DebugEvent evt;
evt.type = DebugEventType::EVT_TICKET_EXPIRED;
DispatchEvent(evt);
}
catch (...)

if (result != Rejected)
{
LOG_TRACE("HTTP response: accepted=%d rejected=%d", accepted, rejected);
} else
{
LOG_ERROR("HTTP response: JSON parsing failed");
LOG_TRACE("HTTP response: all rejected");
}
#else
UNREFERENCED_PARAMETER(response);
Expand Down
Loading