Add a glob matcher #743
Open
Add a glob matcher #743
+253
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Jan 21, 2026
DHowett
approved these changes
Jan 21, 2026
DHowett
requested changes
Jan 22, 2026
| // For convenience, /**/ also matches /. | ||
| if px >= 3 | ||
| && px < pattern.len() | ||
| && pattern[px] == b'/' |
Member
There was a problem hiding this comment.
Should we use is_separator so we support \**\ as well?
| } else { | ||
| // single star - does not match path separators | ||
| // Try to match at nx. If that doesn't work out, restart at nx+1 next. | ||
| next_px = px; |
Member
There was a problem hiding this comment.
You never reset is_double_star. I feel like that means **/foo/*/bar will match a/b/c/foo/d/e/f/bar incorrectly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports
*and**patterns. That's enough for our upcoming purposes.