-
Notifications
You must be signed in to change notification settings - Fork 40
Update Additional Features draft doc, include version features #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qmuntal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, add a TODO section for the TLS settings aligned with MS policies. That is orthogonal to the system-provided crypto. I'll fill it in a follow-up PR.
Co-authored-by: Quim Muntal <qmuntaldiaz@microsoft.com>
|
I added some content for the TLS alignment feature based on the patch's godebug doc, could still probably use filling in (potentially a ref to more details in FIPS doc). |
qmuntal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++!
|
Maybe not for this round but something kept bugging me and then I realised what it was. Should we consider having the versions tabbed, or in a dropdown like I see on other major public fdocs pages for build tools like Gradle or versions of Java? I might be very wrong abotu the Ux of that given what you're trying to convey here sometimes but thought I'd mention it, |
gdams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I agree with Martijn that we might be able to present this information in a better way but I like to move fast and iterate with docs
Unfortunately, we don't have these kinds of tools in Markdown, the best we have is An idea @gdams brought up offline (or something similar that led to this? 😄) is to maybe get this info accessible via |
Simplify, focus on features without exhaustively explaining enable/disable, and fill out the list. Include a specific note about security (regarding our crypto changes) to have another chance to clear up any misunderstanding about that.