-
Notifications
You must be signed in to change notification settings - Fork 83
CI/CD - Test pipeline #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
05a89a6
af676fc
5a4d01e
22fd5f5
0080d92
059daa9
7f6de0c
4f23173
5bf14d4
0687eec
ae05143
1ecbcda
8e8d286
4d7d6c4
82734d4
db9e12b
709680b
c4213bf
6c91e2f
abaf410
fde24d4
6bd6895
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,7 @@ RUN apt-get update && \ | |
| automake \ | ||
| bc \ | ||
| build-essential \ | ||
| ca-certificates \ | ||
| curl \ | ||
| dmidecode \ | ||
| ffmpeg \ | ||
|
|
@@ -50,7 +51,13 @@ RUN apt-get update && \ | |
| util-linux \ | ||
| vim \ | ||
| wget \ | ||
| software-properties-common \ | ||
| && \ | ||
| add-apt-repository -y ppa:longsleep/golang-backports && \ | ||
| apt-get update && \ | ||
| apt-get install -y golang-1.24-go=1.24* && \ | ||
| update-alternatives --install /usr/bin/go go /usr/lib/go-1.24/bin/go 100 && \ | ||
| update-alternatives --install /usr/bin/gofmt gofmt /usr/lib/go-1.24/bin/gofmt 100 && \ | ||
| apt-get autoremove && \ | ||
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* /tmp/* /opt/cmake-3.14.6-Linux-x86_64 | ||
|
|
@@ -149,7 +156,12 @@ ADD dockerfile/etc /opt/microsoft/ | |
| WORKDIR ${SB_HOME} | ||
|
|
||
| ADD third_party third_party | ||
| RUN make -C third_party cuda -o nvbandwidth | ||
| # Install Rust temporarily for wandb build (required by megatron_lm target), then remove | ||
| RUN curl https://sh.rustup.rs -sSf | sh -s -- -y && \ | ||
|
||
| . /root/.cargo/env && \ | ||
| make -C third_party cuda -o nvbandwidth && \ | ||
| rustup self uninstall -y && \ | ||
| rm -rf /root/.cargo /root/.rustup | ||
|
|
||
| ADD . . | ||
| RUN python3 -m pip install --upgrade setuptools==65.7 importlib_metadata==6.8.0 && \ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the third-party PPA
ppa:longsleep/golang-backportsand installinggolang-1.24-gofrom it introduces a supply-chain risk because the build runs package installation scripts from an external, mutable repository with root privileges. If that PPA or its distribution path is compromised, an attacker could ship a malicious Go toolchain that executes during image build and later inside any container based on this image. Prefer using an official, vendor-maintained source or a pinned, verified artifact (e.g., with a checksum or signature) so the exact bits executed in the build are controlled and auditable.