fix: handle resource errors using NativeErrorCode instead of localized message #646
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue resource error were not handled correctly on non-English environments.
Previously, the code checked both
err.Messageanderr.NativeErrorCode, which caused the logic to fail when the error message was localized.The screenshot below demonstrates that, on my environment,
err.Messageis displayed in Japanese.Now, the check relies solely on
err.NativeErrorCodefor the following cases:1812(ERROR_RESOURCE_DATA_NOT_FOUND)1813(ERROR_RESOURCE_TYPE_NOT_FOUND)This ensures consistent resource error handling regardless of the system language.
Microsoft Reviewers: Open in CodeFlow