-
Notifications
You must be signed in to change notification settings - Fork 562
update schema url point to the actual location #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update schema url point to the actual location #884
Conversation
tadasant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping in on this!
| "$schema": { | ||
| "description": "JSON Schema URI for this server.json format", | ||
| "example": "https://static.modelcontextprotocol.io/schemas/2025-12-11/server.schema.json", | ||
| "example": "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/server.schema.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the example the static. URL since that is more representative of what should live here
| format: uri | ||
| description: JSON Schema URI for this server.json format | ||
| example: "https://static.modelcontextprotocol.io/schemas/2025-12-11/server.schema.json" | ||
| example: "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/server.schema.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this one
| { | ||
| "$comment": "This file is auto-generated from docs/reference/api/openapi.yaml. Do not edit manually. Run 'make generate-schema' to update.", | ||
| "$id": "https://static.modelcontextprotocol.io/schemas/draft/server.schema.json", | ||
| "$id": "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/server.schema.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "$id": "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/server.schema.json", | |
| "$id": "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/draft/server.schema.json", |
Just for clarity, I think we should preserve draft in the ID; which means we should move the file inside a folder called draft
Motivation and Context
This PR ensures that the draft URL points to the actual draft schema
improvement suggested in #814
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context