Add package copts toolchain attribute and flags #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows passing extra options to 'mojo package'. These aren't mirrored from the other mojo flags since this subcommand doesn't accept the same flags, but there are some flags that might be useful to pass.
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Jan 13, 2026
This pulls in modular/rules_mojo#70 which lets us enable `-Werror` on CI to make sure no mojo warnings sneak by MODULAR_ORIG_COMMIT_REV_ID: d7e66c240145c6278fddfa7fc05879d4479db975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing extra options to 'mojo package'. These aren't
mirrored from the other mojo flags since this subcommand doesn't accept
the same flags, but there are some flags that might be useful to pass.