-
Notifications
You must be signed in to change notification settings - Fork 1
feat: implement rokt launcher into initForwarder #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement rokt launcher into initForwarder #2
Conversation
* development: Set up initial kit configuration (#3)
rmi22186
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work getting this going! i have some minor comments. nothing blocking release though.
| if (window['Rokt'] && eventQueue.length > 0) { | ||
| for ( | ||
| var i = 0; | ||
| i < eventQueue.length; | ||
| i++ | ||
| ) { | ||
| processEvent(eventQueue[i]); | ||
| } | ||
| eventQueue = []; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a use case for an mparticle event to be passed to the Rokt SDK for processing? I don't think so. It doesn't hurt to have this, but if Rokt never processes mParticle events, then this can be removed.
| if (window['Rokt'] && eventQueue.length > 0) { | |
| for ( | |
| var i = 0; | |
| i < eventQueue.length; | |
| i++ | |
| ) { | |
| processEvent(eventQueue[i]); | |
| } | |
| eventQueue = []; | |
| } |
Co-authored-by: Robert Ing <ring@mparticle.com>
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)