Fpl basecase clean2 #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 77.39% 78.00% +0.61%
==========================================
Files 62 63 +1
Lines 5866 6057 +191
Branches 901 961 +60
==========================================
+ Hits 4540 4725 +185
+ Misses 1129 1111 -18
- Partials 197 221 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean2
branch
from
bfef209 to
d31579e
Compare
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean2
branch
from
4fdc771 to
be4637c
Compare
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean2
branch
from
7fc1dc3 to
19c33f9
Compare
Improve the 4D base case of FPL:
* c/hv_priv.h: Remove x_aux from dlnote_t, x is const again.
* c/hv.c:
- Remove references to x_aux.
- Also maintain a list sorted according to z coordinate.
- Allocate (once) the auxiliar data structures used in the base case.
* c/hv4d_priv.h (onec4dplusU):
- Reconstruct the 3D base of the 4D contribution by sweeping the (sorted) z list.
- Use an auxiliar dlnode_t list (list_aux) and an auxiliar double vector (x_aux) for modified points.
- Take advantage of sweeping points in ascending order of the z-coordinate (continue_base_update_z_closest).
* c/hv.c: Use ->vol instead of ->x for the auxiliary vectors.
(fpli_hv4d): Delete unused.
* c/hv4d_priv.h: Simplify code, fix warnings, add more asserts and comments.
(update_bound_3d): New.
avoid newp != the_point. more cleanups hv4d_priv.h: Move newp_aux++ within the if(). hv4d_priv.h: Avoid warning with DEBUG=0.
… ->vol and auxiliary points.
* hv4d_priv.h (update_bound_3d): Delete. Replaced by upper_bound().
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean2
branch
from
476c869 to
4bf7044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.