feature: Skip auto-review from owners who have already reviewed but not approved #85
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @ashindemm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the automated review request process by intelligently identifying and excluding reviewers who have previously provided feedback but not an approval. This enhancement aims to optimize the review workflow by avoiding redundant requests, ensuring that review re-requests are directed only to relevant parties who have not yet engaged or approved. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ashindemm
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new function GetReviewedButNotApproved to identify reviewers who have requested changes or commented on the pull request without approving it. This functionality is then used to avoid re-requesting reviews from teams that are already engaged, particularly when fulfilling a min_reviews requirement. The overall logic is sound and well-implemented. I have one suggestion to improve code maintainability.
internal/github/gh.go
Outdated
| if _, seen := userReviewStates[reviewingUser]; !seen { | ||
| state := review.GetState() | ||
| // Only track non-approved states (CHANGES_REQUESTED or COMMENTED) | ||
| if state == "CHANGES_REQUESTED" || state == "COMMENTED" { |
There was a problem hiding this comment.
For better maintainability and to avoid potential typos, it's recommended to use the predefined constants from the go-github library for review states instead of magic strings. The library provides constants like github.ReviewStateChangesRequested and github.ReviewStateCommented.
| if state == "CHANGES_REQUESTED" || state == "COMMENTED" { | |
| if state == github.ReviewStateChangesRequested || state == github.ReviewStateCommented { |
2 participants
Related PR(s)
#77
Related Issue(s)
Summary / Background
Currently, if a PR needs approval from a single codeowner, and someone has reviewed the PR, but just commented/requested changes and they submit their review, the same codeowner group is re-pinged for review.
This PR adds logic to check if a codeowner has reviewed a PR already (but not approved) and then skips it from the auto-review loop.