fix: FreeBSD compilation errors (issue #174) #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2026 03:20
Fix issue #174: FreeBSD was excluded from including the POSIX semaphore implementation header. The previous conditional compilation had an empty branch for LIBIPC_OS_FREEBSD, causing 'no member named sync in namespace ipc::detail' errors. FreeBSD supports POSIX semaphore APIs (sem_open, sem_wait, sem_post, etc.), so it should use the same semaphore_impl.h as Linux and QNX.
Fix issue #174: Several functions in mutex.h and condition.h were using the 'log' variable without first calling LIBIPC_LOG() macro, which defines the 'log' variable. This caused FreeBSD compiler errors like 'unexpected namespace name log: expected expression'. Changes in mutex.h: - Add LIBIPC_LOG() at the beginning of open() - Add LIBIPC_LOG() at the beginning of try_lock() - Fix lambda capture in close() to include '&log' - Fix lambda capture in clear() to include '&log' Changes in condition.h: - Add LIBIPC_LOG() at the beginning of clear() - Add LIBIPC_LOG() at the beginning of notify() - Add LIBIPC_LOG() at the beginning of broadcast()
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 75.33% 75.20% -0.13%
==========================================
Files 68 68
Lines 4265 4263 -2
Branches 470 470
==========================================
- Hits 3213 3206 -7
- Misses 846 849 +3
- Partials 206 208 +2
🚀 New features to boost your workflow:
|
Contributor
|
Yes this fixes the compiler failure thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the FreeBSD compilation errors reported in issue #174.
Problems Fixed
1. Missing semaphore implementation for FreeBSD
Error:
semaphore.cpp:69:5: error: no member named 'sync' in namespace 'ipc::detail'Cause: The conditional compilation in
semaphore.cpphad an empty branch forLIBIPC_OS_FREEBSD, sosemaphore_impl.hwas not included.Fix: Include
posix/semaphore_impl.hfor FreeBSD since it supports POSIX semaphore APIs.2. Missing LIBIPC_LOG() macro calls
Error:
mutex.h:130:13: error: unexpected namespace name 'log': expected expressionCause: Several functions used the
logvariable (created byLIBIPC_LOG()macro) without first calling the macro. The compiler then interpretedlogas theipc::lognamespace instead of a variable.Fix:
LIBIPC_LOG()calls at the beginning of affected functions&logwhere neededChanges
src/libipc/sync/semaphore.cpp: Includesemaphore_impl.hfor FreeBSDsrc/libipc/platform/posix/mutex.h: AddLIBIPC_LOG()toopen()andtry_lock(); fix lambda captures inclose()andclear()src/libipc/platform/posix/condition.h: AddLIBIPC_LOG()toclear(),notify(), andbroadcast()Testing
These changes fix the compilation errors on FreeBSD platform as reported in the build log.
Closes #174