fix(imap): Add support for mail services that enforce a client id #12259
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDreschner
requested changes
Jan 16, 2026
Contributor
There was a problem hiding this comment.
The unit tests fail with this change:
1) OCA\Mail\Tests\Integration\Service\MailTransmissionIntegrationTest::testReplaceDraft
Undefined array key "capability"
Additionally, I would prefer to see the RFC number in the commit message and/or code in case someone looks for the supported RFCs.
Some mail services (e.g. mail163.com) do require an imap id to be given. Without further configuration sendID just sends NIL as ID. RFC: https://datatracker.ietf.org/doc/html/rfc2971 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/12151/send-client-id
branch
from
93e916f to
0f64a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12151
Some mail services (e.g. mail163.com) do require an imap id to be given.
Without further configuration sendID just sends NIL as ID.