fix: it is not possible to clear non-mandatory selects during inline edit #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edit Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
bugfix/fix-clear-selection-inline-edit
branch
from
baced17 to
442f666
Compare
enjeck
approved these changes
Jan 27, 2026
Contributor
enjeck
left a comment
enjeck
left a comment
There was a problem hiding this comment.
Tested and works, thanks!
Contributor
|
CI is currently broken, will merge when that's fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a conflict between
NcSelectcomponents that are used in pagination footer and inline edit. This PR fixes it for select/multu-select/user-groups column typesBefore
After
And vise versa for popup edit field: we're displaying clear button even for mandatory columns
Related to #2054 (comment)