Skip to content

Conversation

@Koc
Copy link
Contributor

@Koc Koc commented Jan 25, 2026

  1. instanciate a column business in a single place ColumnsHelper::getColumnBusiness() instead of duplication:
    • ImportService::parseValueByColumnType()
    • RowService::getColumnBusiness()
  2. memoize column business instance per column type in a factory and per column id in a import to speedup performance a bit
  3. SuperBusiness now implements IColumnTypeBusiness
  4. make $column non-nullable in a column business classes and remove redundant checks. I can't find any use-case when it can be nullable

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/refactor-business-classes branch from e4b7806 to b7d99fc Compare January 25, 2026 16:12
@Koc Koc marked this pull request as ready for review January 25, 2026 16:15
@Koc Koc requested review from blizzz and enjeck as code owners January 25, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants