Skip to content

chore/disable failing playwright test #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-nextcloud wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore/disable failing playwright test #8183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59d9cab
chore(test): remove assertion broken by viewer regression
max-nextcloud Jan 23, 2026
ecee538
chore(test): extend timeouts for flaky slow playwright test
max-nextcloud Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions playwright/e2e/change-mime-type.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ test.describe('Changing mimetype from markdown to plaintext', () => {
file,
viewer,
}) => {
test.slow()
await editor.typeHeading('Hello world')
await viewer.close()
const plaintext = await file.move('test.txt')
Expand All @@ -36,6 +37,7 @@ test.describe('Changing mimetype from plain to markdown', () => {
file,
viewer,
}) => {
test.slow()
await editor.type('## Hello world')
await expect(editor.content).toHaveText('## Hello world')
await viewer.close()
Expand Down
3 changes: 2 additions & 1 deletion playwright/e2e/versions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,6 @@ async function checkVersions(versions: Locator, editor: EditorSection) {
await expect(editor.getHeading({ name: 'V2' })).toBeVisible()
// current version
await versions.getByRole('link').nth(0).click()
await expect(editor.getHeading({ name: 'V3' })).toBeVisible()
// https://github.com/nextcloud/viewer/issues/3052
// await expect(editor.getHeading({ name: 'V3' })).toBeVisible()
}
2 changes: 1 addition & 1 deletion playwright/support/fixtures/Node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@

async open() {
// loading the file list may take a while
const timeout = 10_000
const timeout = 15_000
await this.page.goto(`f/${this.id}`)
await expect(this.page.getByLabel(this.name, { exact: true }))
.toBeVisible({ timeout })

Check failure on line 84 in playwright/support/fixtures/Node.ts

View workflow job for this annotation

GitHub Actions / test

[chromium] › playwright/e2e/change-mime-type.spec.ts:16:3 › Changing mimetype from markdown to plaintext › resets the document session and indexed db 

  1) [chromium] › playwright/e2e/change-mime-type.spec.ts:16:3 › Changing mimetype from markdown to plaintext › resets the document session and indexed db 
    Error: expect(locator).toBeVisible() failed

    Locator: getByLabel('empty.md', { exact: true })
    Expected: visible
    Timeout: 15000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" with timeout 15000ms
      - waiting for getByLabel('empty.md', { exact: true })


       at support/fixtures/Node.ts:84

      82 | 		await this.page.goto(`f/${this.id}`)
      83 | 		await expect(this.page.getByLabel(this.name, { exact: true }))
    > 84 | 			.toBeVisible({ timeout })
         | 			 ^
      85 | 	}
      86 |
      87 | 	async move(newName: string) {
        at Node.open (/home/runner/actions-runner/_work/text/text/playwright/support/fixtures/Node.ts:84:5)
        at /home/runner/actions-runner/_work/text/text/playwright/e2e/change-mime-type.spec.ts:13:2
}

async move(newName: string) {
Expand Down
Loading