-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Metadata propagation in source, source transformer, mapper, sink #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
… transform, mapper and sinker Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
yhl25
reviewed
Jan 27, 2026
Contributor
yhl25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use function overloading and introduce a method for constructing on success response using the
Datum. - Remove onSuccess function for proto and use a private method.
- Add an example(could be a follow-up PR).
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
yhl25
reviewed
Jan 28, 2026
examples/src/main/java/io/numaproj/numaflow/examples/sink/onsuccess/OnSuccess.java
Outdated
Show resolved
Hide resolved
src/test/java/io/numaproj/numaflow/shared/UserMetadataTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
yhl25
approved these changes
Jan 30, 2026
yhl25
reviewed
Jan 30, 2026
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #205
Notes
Change in OnSuccess message metadata
With the introduction of a shared
UserMetadataclass, theuserMetadatamember inMessageclass for OnSuccess message has been changed from:to
This is done so that the users can utilize the same UserMetadata for onSuccess message without conversion.
Furthermore, the new UserMetadata has been implemented in its current form since it allows parity with other SDKs (inner data holds Map of Map, instead of Map of KeyValueGroup) and also prevents the extra step of converting proto KeyValueGroup object to local KeyValueGroup class object and back.
Format of userMetadata and systemMetadata
Both
UserMetadataandSystemMetadataclasses have inner data in the format: