-
-
Notifications
You must be signed in to change notification settings - Fork 133
Add Chinese translations #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All credits to Chunlin Fang (`@Qiyu8`).
| sidebar: false | ||
| --- | ||
|
|
||
| ### 2021 NumPy survey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The news page has been override by @InessaPawson 's "Make an announcement about the 2021 NumPy survey", Not only the Chinese translation is affected, but the translation of other languages is also affected. should we fix this content? It's looks like the translation process is conflicted with document maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think this is what I mentioned at #55 (comment)
|
What is the status of this? |
It's kind of stuck on lack of bandwidth from me to finish it. Merging this PR seems not too far off; just one review comment to deal with. Actually launching the translations on the public site is a bit more involved - and also I'm expecting that we'll get a larger amount of contributions at that point, and I at least have no bandwidth to respond to them at the moment. @InessaPawson and I talked recently about how to get translations moving; it'll take a few months probably. |
|
@rgommers The translations workflow has changed quite a bit since this PR was opened. Just checking in to see if you're still planning to merge it? |
|
This has slipped through our migration - I will check what we can do. Thanks for the ping! |
@melissawm Hey, Melissa! Did you have a chance to take a look at this? It’d be great to address the remaining PRs related to translations in this repo. |
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
b6e4883 to
a3c0c07
Compare
|
@agriyakhetarpal can you help me understand what's going on with the failure here? It looks like the shortcode for the figure is not working on the user survey page, but it looks correct to me... |
|
Hi @melissawm, I think the theme submodule has not been updated. It still points to the v0.21 release: https://github.com/rgommers/numpy.org/tree/47cd8262c00f5b831a761361b3f7a3918fa94d58/themes |
|
That did it, thanks! Now on to the other failures... |
a47dcb1 to
d1c8502
Compare
|
Yay! This is now building, and I tried updating some of the pages that were clearly outdated. Some of those (like the installation page) will need to be re-translated, but that is reasonable since the content has changed so much since this initial PR was created. I'd ask folks to take a look (ideally someone who can read the content) to validate that this is a good start, but at least it's buildling 🎉 |

This integrates the Crowdin translations into
master, fixes a number of rendering issues, and makes Chinese translations show up in PR previews (but not yet on numpy.org, we haven't launched yet).In the PR preview it is now easy to see where there are still gaps in translations.
Note, to build the site locally with translations, use: