mini.pick: allow cancel of grep #2227
Closed
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit there was no graceful way to cancel the pattern input of the grep picker. Hitting `ctrl-c` created an error. Any other natural form of cancellation returned an empty string, which blocked the picker in large repos for quite some time. Replace `vim.fn.input` with `vim.ui.input` which properly distinguishes a cancellation of the prompt from an empty input string. Signed-off-by: ldelossa <louis.delos@gmail.com>
Member
|
Thanks for the PR! All 'mini.nvim' modules (well, except a single occasion) intentionally use Until then, replacing with As per respecting cancel in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit there was no graceful way to cancel the pattern
input of the grep picker.
Hitting
ctrl-ccreated an error.Any other natural form of cancellation returned an empty string, which
blocked the picker in large repos for quite some time.
Replace
vim.fn.inputwithvim.ui.inputwhich properly distinguishesa cancellation of the prompt from an empty input string.