Skip to content

fix(oocana): convert CredentialInput to dataclass #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leavesster wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(oocana): convert CredentialInput to dataclass #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions oocana/oocana/credential.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
from dataclasses import dataclass

__all__ = ["CredentialInput"]


@dataclass(frozen=True)
Copy link

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other dataclasses in this package are declared with kw_only=True (e.g., oocana/oocana/handle.py:7, oocana/oocana/data.py:41, oocana/oocana/schema.py:38). To keep CredentialInput consistent and avoid accidental positional-argument usage, consider adding kw_only=True here as well.

Copilot uses AI. Check for mistakes.
class CredentialInput:
def __init__(self, type: str, id: str):
self.type = type
self.id = id
"""
Represents a credential input for authentication queries.

Attributes:
type: The type of credential (e.g., 'oauth', 'api_key')
id: The unique identifier for the credential
"""
type: str
id: str
Loading