Add "Let's find each other on Discord!" to quick chat #2873
Conversation
|
user seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
WalkthroughThis PR adds a new QuickChat misc entry Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-08-16T10:52:08.292ZApplied to files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @resources/lang/sl.json:
- Line 426: Replace the Lithuanian value for the JSON key "discord" with a
proper Slovenian translation (e.g., "Poiščimo se na Discordu!" or "Najdimo se na
Discordu!") in the resources/lang/sl.json file for the "discord" entry, then
have a native Slovenian speaker review and approve the exact wording before
merging.
🧹 Nitpick comments (4)
resources/lang/tr.json (1)
421-421: Non-English locale file updated in regular PR.Based on learnings, translation files in
resources/lang/*.json(excepten.json) should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files. Regular PRs should only updateen.jsonwhen adding or modifying translation keys.Consider removing this change and letting the translation be added through the dedicated translation workflow.
resources/lang/zh-CN.json (1)
482-482: Non-English locale file updated in regular PR.Based on learnings, this Simplified Chinese locale file should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files. The
en.jsonupdate is fine, but these locale-specific translations should go through the community translation workflow.Consider removing this change and letting native speakers add the translation through the dedicated process.
resources/lang/mk.json (1)
421-421: Non-English locale file updated in regular PR.Based on learnings, this Macedonian locale file should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files.
Consider removing this change and letting community translators handle it through the dedicated workflow.
resources/lang/eo.json (1)
426-426: Non-English locale file updated in regular PR.Based on learnings, this Esperanto locale file should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files.
Consider removing this change and letting it go through the dedicated translation workflow.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (20)
resources/QuickChat.jsonresources/lang/bg.jsonresources/lang/de.jsonresources/lang/el.jsonresources/lang/en.jsonresources/lang/eo.jsonresources/lang/fa.jsonresources/lang/fi.jsonresources/lang/fr.jsonresources/lang/hu.jsonresources/lang/ja.jsonresources/lang/ko.jsonresources/lang/mk.jsonresources/lang/nl.jsonresources/lang/pl.jsonresources/lang/ru.jsonresources/lang/sl.jsonresources/lang/tr.jsonresources/lang/uk.jsonresources/lang/zh-CN.json
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: andrewNiziolek
Repo: openfrontio/OpenFrontIO PR: 1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Learnt from: TheGiraffe3
Repo: openfrontio/OpenFrontIO PR: 884
File: resources/lang/en.json:456-461
Timestamp: 2025-08-16T10:52:08.292Z
Learning: In OpenFrontIO, translation files in resources/lang/*.json (except en.json) should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files. Regular PRs should only update en.json when adding or modifying translation keys.
📚 Learning: 2025-08-16T10:52:08.292Z
Learnt from: TheGiraffe3
Repo: openfrontio/OpenFrontIO PR: 884
File: resources/lang/en.json:456-461
Timestamp: 2025-08-16T10:52:08.292Z
Learning: In OpenFrontIO, translation files in resources/lang/*.json (except en.json) should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files. Regular PRs should only update en.json when adding or modifying translation keys.
Applied to files:
resources/lang/fr.jsonresources/lang/mk.json
📚 Learning: 2025-06-02T14:27:37.609Z
Learnt from: andrewNiziolek
Repo: openfrontio/OpenFrontIO PR: 1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Applied to files:
resources/lang/fr.json
🔇 Additional comments (15)
resources/QuickChat.json (1)
147-150: LGTM!The new
discordquick chat entry is well-structured. SettingrequiresPlayertofalseis correct since the message doesn't need to reference another player. The placement at the start of themiscarray gives it good visibility.resources/lang/fi.json (1)
421-421: Non-English locale file updated in regular PR.Based on learnings, translation files in
resources/lang/*.json(excepten.json) should only be updated in dedicated translation PRs titled "mls" made by Aotumori. Regular PRs should only updateen.jsonwhen adding or modifying translation keys.The translation content itself looks correct. Consider removing this change and letting the community translators handle the Finnish translation in a dedicated PR.
resources/lang/bg.json (1)
482-482: Non-English locale file updated in regular PR.Based on learnings, translation files in
resources/lang/*.json(excepten.json) should only be updated in dedicated translation PRs titled "mls" made by Aotumori. Regular PRs should only updateen.jsonwhen adding or modifying translation keys.The translation content looks correct. Consider removing this change and letting the community translators handle the Bulgarian translation in a dedicated PR.
resources/lang/de.json (1)
482-482: Non-English locale file updated in regular PR.Based on learnings, translation files in
resources/lang/*.json(excepten.json) should only be updated in dedicated translation PRs titled "mls" made by Aotumori. Regular PRs should only updateen.jsonwhen adding or modifying translation keys.The translation content looks correct. Consider removing this change and letting the community translators handle the German translation in a dedicated PR.
resources/lang/ja.json (1)
482-482: Non-English locale file updated in regular PR.Based on learnings, translation files in
resources/lang/*.json(excepten.json) should only be updated in dedicated translation PRs titled "mls" made by Aotumori. Regular PRs should only updateen.jsonwhen adding or modifying translation keys.The translation content looks correct. Consider removing this change and letting the community translators handle the Japanese translation in a dedicated PR.
resources/lang/ko.json (1)
482-482: Non-English locale file updated in regular PR.Based on learnings, translation files in
resources/lang/*.json(excepten.json) should only be updated in dedicated translation PRs titled "mls" made by Aotumori. Regular PRs should only updateen.jsonwhen adding or modifying translation keys.The translation content looks correct. Consider removing this change and letting the community translators handle the Korean translation in a dedicated PR.
resources/lang/pl.json (1)
462-462: Translation looks correct.The Polish text accurately conveys "Let's find each other on Discord!" Based on learnings, non-English locale files are typically updated in dedicated translation PRs by community translators. If the maintainers prefer that workflow, this entry could be deferred to a translation PR.
resources/lang/en.json (1)
586-586: LGTM!The new Discord quick chat entry is placed correctly under
chat.miscand the message text is clear and friendly.resources/lang/uk.json (1)
482-482: Translation looks correct.The Ukrainian text accurately conveys the intended message. Based on learnings, non-English locale files are typically updated in dedicated translation PRs, but the content itself is good.
resources/lang/nl.json (1)
482-482: Translation looks correct.The Dutch text
"Laten we elkaar vinden op Discord!"is accurate and sounds natural. Based on learnings, non-English locale files are typically updated in dedicated translation PRs, but the content itself is good.resources/lang/fa.json (1)
482-482: Non-English locale file updated in a regular PR.Based on learnings, translation files in
resources/lang/*.json(excepten.json) should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files.Consider removing this change and letting community translators handle it in a dedicated translation PR. This keeps technical changes separate from translation content updates.
resources/lang/el.json (1)
462-462: Non-English locale file updated in a regular PR.Based on learnings, this Greek translation should be handled in a dedicated "mls" translation PR by community translators, not in this feature PR. Regular PRs should only update
en.jsonwhen adding new translation keys.resources/lang/hu.json (1)
426-426: Non-English locale file updated in a regular PR.Based on learnings, Hungarian translations should come through the dedicated "mls" translation workflow. This approach ensures native speakers handle translations accurately while technical changes can proceed independently.
resources/lang/ru.json (1)
482-482: Non-English locale file updated in a regular PR.Based on learnings, Russian translations should be added through the dedicated "mls" translation PR workflow. The project maintainers separate technical changes from translation updates to ensure accurate translations from native speakers.
resources/lang/fr.json (1)
482-482: Non-English locale file updated in a regular PR.Based on learnings, French translations should come through the dedicated "mls" translation workflow managed by Aotumori.
Recommendation for all locale files in this PR: Keep only the
en.jsonchanges (which adds the newdiscordkey). Remove changes tofa.json,el.json,hu.json,ru.json,fr.json, and any other non-English locale files. The translation team will add proper translations in a follow-up "mls" PR.This workflow ensures:
- Technical changes ship quickly
- Native speakers provide accurate translations
- Translation quality stays high
|
Translations are done via Crowdin, please only change en.json |
|
Not sure if this is really needed - it might be pretty hard to find someone with this string of text anyway, maybe it should be "Find me in the Official OpenFront.io discord! I will be in the #xxxx channel" or something idk...? |
Duwibi
left a comment
Duwibi
left a comment
There was a problem hiding this comment.
It seems like a good idea to my. Once again, as FloPinguin said, only en.json should be changed. Everything else is done through community translation via Crowdin :)
5 participants
If this PR fixes an issue, link it below. If not, delete these two lines.
Resolves #(issue number)
Description:
Add a button to ask a player to post something on Discord so you can find each other. It would be also nice to add a special topic for this on the Discord channel
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
uforgoturspanishlessons