-
Notifications
You must be signed in to change notification settings - Fork 596
More interpolation types in Tabular. #3413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
332056f to
1f7d62c
Compare
remove unused function
|
While working through the open PRs I just noticed that a conflict has crept into this one |
|
I fixed the conflicts. |
paulromano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @GuySten and sorry it has taken me a long time to look this one over. In general, I feel like the addition of the Lambert W function on the C++ side is a lot of code for something that would almost never be used. I would be comfortable adding the sampling routines on the Python side (where we already have access to lambertw from scipy) but would prefer not to include the C++ portion. If someone really needs to sample a lin-log distribution on the C++ side, I think a better option is to just linearize it first and we already have the openmc.data.grid.linearize function that can handle that.
|
I removed lin log interpolation from cpp side. |
Description
This pull request implement more interpolation types in Tabular by using inverse transform sampling algorithm.
Fixes #2409.
Checklist