security/acme-client: Fix bug in TransIP secret path and add make it possible to obtain a global access token from TransIP #5166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the configuration file, account.conf, was stored using the GUI there were placed two slashes in the file path to secret.pem, where it should be one. Deu too this bug, the dns api of acme.sh did not recognized the file path and exited with code 1, with the message that the key was not set.
The TransIP dns api and the acme.sh api for TransIP support the possibility to create a global access token. With a global access token, the api call to TransIP can be amde from every ip adress. There is a new button in the client configuration for TransIP, and this will be added to the account configuration file, which is used by acme.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When the API key of TransIP is stored, it is stored in a file. The location of this file will be placed in the account.conf file. The location of the file that is stored in account.conf has two slashes in the file path to secret.key, where it should be one.
Due too this bug, the dns api of acme.sh did not recognized the file path and exited with code 1, with the message that the key was not set.
Solution:
We now check if the path to directory where the secret.key is stored and with a
/, and if so, we will not add another one.New feature:
The TransIP dns api and the acme.sh api for TransIP support the possibility to create a global access token.
With a global access token, the api call to TransIP can be amde from every ip adress.
There is a new button in the client configuration for TransIP, and this will be added to the account configuration file, which is used by acme.sh