#375: Schema Table Updates #392
Open
+76
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed offline, please remove the columnWidth implementation infavor of what we worked on. |
JamesTLopez
requested changes
Jan 26, 2026
JamesTLopez
left a comment
JamesTLopez
left a comment
There was a problem hiding this comment.
Small changes! But otherwise solid work 👍
Comment on lines
+48
to
+58
| export const Mobile: Story = { | ||
| parameters: { | ||
| viewport: { defaultViewport: 'mobile1' }, | ||
| }, | ||
| }; | ||
|
|
||
| export const MobileLarge: Story = { | ||
| parameters: { | ||
| viewport: { defaultViewport: 'mobile2' }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Minus tablet, I don't believe its beneficial to have views for Mobile and MobileLarge as mobile is not a point of focus.
Instead, we can have different story's for testing viewports in the ticket listed:
Test minimum column widths at common viewport sizes (1920px, 1440px, 1280px, 1024px)
If not thats fine, otherwise lets remove Mobile and MobileLarge stories
| @@ -0,0 +1,64 @@ | |||
| /* | |||
| * | |||
| * Copyright (c) 2025 The Ontario Institute for Cancer Research. All rights reserved | |||
Comment on lines
+40
to
+41
| max-width: 15vw; | ||
| min-width: 325px; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #375
Summary
Makes several updates to the schema table such as fixing text consistency, improving column behaviour via decreasing the width of the field column, and improving table header visual density.
Description of Changes
value"
Readiness Checklist
.env.schemafile and documented in the README