[multicast] prevent VLAN translation via match key enforcement #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107, which now properly
passes.
Stacked on #189.
This adds VLAN-aware NAT ingress matching to prevent cross-VLAN translation.
Previously, a packet arriving with VLAN 100 destined to a multicast group
configured for VLAN 200 would be NAT encapsulated and forwarded, effectively
translating the packet to the wrong customer's network.
Includes:
NAT ingress table matching (mcast_nat.rs, mod.rs):
VLAN header validity, and VLAN ID
from underlay) and correctly tagged (for customer packets)
Multicast router VLAN handling (sidecar.p4):
Rollback changes:
Counter fix:
MULTICAST_TAG_UNDERLAY_EXTERNAL that were not decapped. The check for
== MULTICAST_TAG_UNDERLAY excluded these packets, causing them to fall
through to the external counter.