Skip to content

Conversation

@keldonin
Copy link
Collaborator

This one is about shortening compilation time. Building kryoptic is just taking forever as OpenSSL has to be built. I deactivated tests and docs. We'll see how it goes.

Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
Copilot AI review requested due to automatic review settings January 31, 2026 19:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the CI build time by disabling OpenSSL documentation and test compilation during the build process. The change adds no-docs no-tests flags to the OpenSSL Configure command in the kryoptic-fips workflow.

Changes:

  • Modified OpenSSL Configure command to skip building documentation and tests, reducing compilation time

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
@keldonin
Copy link
Collaborator Author

keldonin commented Jan 31, 2026

That seems to accelerate. However, when looking closer at the logs, openssl is being built twice: once externally (as a dependency), and once through the build of kryoptic crate...

https://github.com/latchset/kryoptic/blob/main/ossl/build.rs

duplication of effort?

Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already an improvement 👌 It'd be good to get to the bottom of this and if possible use packaged versions... maybe we can switch to Fedora for these jobs? CC @Jakuje

Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Jakuje
Copy link
Collaborator

Jakuje commented Feb 2, 2026

That seems to accelerate. However, when looking closer at the logs, openssl is being built twice: once externally (as a dependency), and once through the build of kryoptic crate...

AFAIK the first run should be cached and second run should just call make that should verify the artifacts are already up to date from the first step, but I did not dive into that deeper.

This is already an improvement 👌 It'd be good to get to the bottom of this and if possible use packaged versions... maybe we can switch to Fedora for these jobs? CC @Jakuje

The build of kryoptic itself is fast as it is linking against the system openssl. The only slow pipeline is the kryoptic-fips which really does not have a rpm packaged version as for now.

@keldonin
Copy link
Collaborator Author

keldonin commented Feb 2, 2026

I guess I can squash and merge at this point?

@keldonin
Copy link
Collaborator Author

keldonin commented Feb 2, 2026

I'm not offered the squash-and-merge option, just "Merge pull request"... Something you could enable for the project? Otherwise the branch commits will pollute the commit history. Alternatively, I could rebase, but enabling squash on github is more straightforward.
Thanks!

@wiktor-k
Copy link
Collaborator

wiktor-k commented Feb 2, 2026

I think only @hug-dev can do that... :godmode:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants