-
Notifications
You must be signed in to change notification settings - Fork 90
attempt to accelerate CI by shortening OpenSSL compile time #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR optimizes the CI build time by disabling OpenSSL documentation and test compilation during the build process. The change adds no-docs no-tests flags to the OpenSSL Configure command in the kryoptic-fips workflow.
Changes:
- Modified OpenSSL Configure command to skip building documentation and tests, reducing compilation time
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
|
That seems to accelerate. However, when looking closer at the logs, https://github.com/latchset/kryoptic/blob/main/ossl/build.rs duplication of effort? |
wiktor-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already an improvement 👌 It'd be good to get to the bottom of this and if possible use packaged versions... maybe we can switch to Fedora for these jobs? CC @Jakuje
Jakuje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
AFAIK the first run should be cached and second run should just call
The build of kryoptic itself is fast as it is linking against the system openssl. The only slow pipeline is the kryoptic-fips which really does not have a rpm packaged version as for now. |
|
I guess I can squash and merge at this point? |
|
I'm not offered the squash-and-merge option, just "Merge pull request"... Something you could enable for the project? Otherwise the branch commits will pollute the commit history. Alternatively, I could rebase, but enabling squash on github is more straightforward. |
|
I think only @hug-dev can do that... |
This one is about shortening compilation time. Building kryoptic is just taking forever as OpenSSL has to be built. I deactivated tests and docs. We'll see how it goes.