Skip to content

Conversation

@nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Jan 19, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where internal streams were being incorrectly included in dataset responses.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

Walkthrough

Adds a guard in PrismDatasetRequest::process_stream to skip processing internal streams by querying the stream type via PARSEABLE and returning None if the stream is classified as Internal. This prevents building dataset responses for internal streams.

Changes

Cohort / File(s) Summary
Internal stream filtering
src/prism/logstream/mod.rs
Adds a guard condition to skip internal streams during dataset request processing by checking stream type and returning early if detected.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Internal streams now take a rest,
No need to process every test,
A simple guard, so quick and neat,
Makes dataset handling more discreet! 🌊✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is completely missing. The template requires description, solution rationale, key changes, and testing/documentation checkboxes. Add a comprehensive description explaining the issue, why internal streams should be excluded, what was changed, and confirm testing and documentation requirements were met.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: excluding internal streams from the datasets API, which aligns with the code modification that adds a guard to skip processing internal streams.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@nitisht nitisht merged commit 6dcdd93 into parseablehq:main Jan 19, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants