Vendor encoding conversion code from mbstring #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While mailparse uses mbstring to handle Base64 and QPrint byte encodings, this functionality is deprecated in mbstring and scheduled for removal in PHP 9. Since the needed code will be removed from mbstring, we can give it a new home here in mailparse. This means that mailparse will continue to work under PHP 9. Also, it means that mailparse is no longer dependent on mbstring being compiled into the main PHP binary; it can be used with any PHP binary, even if mbstring is not present.
Author
|
Hmm, Windows build is failing with this error: The failure doesn't seem to have anything to do with the content of the PR. |
|
My environment (Windows 11, x64, PHP-8.6.0-dev (php/php-src@b17b699)) is confirmed works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While mailparse uses mbstring to handle Base64 and QPrint byte encodings, this functionality is deprecated in mbstring and scheduled for removal in PHP 9. Since the needed code will be removed from mbstring, we can give it a new home here in mailparse. This means that mailparse will continue to work under PHP 9. Also, it means that mailparse is no longer dependent on mbstring being compiled into the main PHP binary; it can be used with any PHP binary, even if mbstring is not present.
I've modified function name prefixes from
mbfl_tomb_, so that there are no name conflicts with the functions which are (temporarily) still included in mbstring (but will be removed a bit later).FYA @remicollet @youkidearitai @ndossche @cmb69