Clean up managed labels when clusters no longer match #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements label cleanup logic for the Classifier controller. When a cluster is no longer a match for a Classifier instance, or when the Classifier itself is deleted, the controller now removes all labels it previously managed on those clusters. This ensures no stale metadata remains on the underlying cluster resources. The removal logic is guarded by the KeyManager to prevent the accidental deletion of labels managed by other Classifier instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements label cleanup logic for the Classifier controller. When a cluster is no longer a match for a Classifier instance, or when the Classifier itself is deleted, the controller now removes all labels it previously managed on those clusters.
This ensures no stale metadata remains on the underlying cluster resources.
The removal logic is guarded by the KeyManager to prevent the accidental deletion of labels managed by other Classifier instances.
Fixes #436