Refactor/refactor provable types #388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitunc
commented
Jan 20, 2026
Comment on lines
+44
to
+50
| export class PendingTransaction { | ||
| public readonly hash: string; | ||
|
|
||
| public readonly methodId: string; | ||
|
|
||
| public readonly nonce: string; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Moved it up to fix linting issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In this PR, it is aimed to convert from provable types to non-provable types in out-of-circuit code.
Starting point changes in this refactoring was to implement or convert to JSON type of the followings:
BlockBlockWithResultAnd since they are
TransactionExecutionResultPendingTransactionStateTransitionBatchUntypedStateTransitionNetworkStateEspecially last 3 is used all around the Sequencing and Tracing modules.
Commits
UntypedStateTransition & StateTransitionBatch
UntypedStateTransitionJson0199877 ( rename: 5934a13 )TransactionExecutionResult
TransactionExecutionResultJsonb017bb5PendingTransaction
PrivateMempoold3c9336NetworkState
NetworkStateJsonby inferring it from Struct c29a51dRuntimeProofParametersJsontype withNetworkStateJsonandPendingTransactionJsonTypea4ac392Miscellanous
#### Test
This PR closes #201