Skip to content

⚡ Optimize ShareableArray.defragment byte copy #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

⚡ Optimize ShareableArray.defragment byte copy #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/array/ShareableArray.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,8 @@ export class ShareableArray<T> extends TransferableDataStructure {
*/
private defragment() {
const newData: ArrayBuffer = new ArrayBuffer(this.dataView.byteLength);
const newView = new DataView(newData);
const newUint8Array = new Uint8Array(newData);
const oldUint8Array = new Uint8Array(this.dataMem);

let currentDataStart = 0;

Expand All @@ -956,9 +957,10 @@ export class ShareableArray<T> extends TransferableDataStructure {
const currentObjectLength = this.dataView.getUint32(currentDataPos + 4) + ShareableArray.DATA_OBJECT_OFFSET;

// Copy all bytes to the new array
for (let i = 0; i < currentObjectLength; i++) {
newView.setUint8(currentDataStart + i, this.dataView.getUint8(currentDataPos + i));
}
newUint8Array.set(
oldUint8Array.subarray(currentDataPos, currentDataPos + currentObjectLength),
currentDataStart
);

// Update the position where this is stored in the index array
this.indexView.setUint32(ShareableArray.INDEX_TABLE_OFFSET + 4 * i, currentDataStart);
Expand All @@ -968,8 +970,7 @@ export class ShareableArray<T> extends TransferableDataStructure {
}

// Replace the data from the old data array with the data in the array
const oldArray = new Uint8Array(this.dataMem);
oldArray.set(new Uint8Array(newData));
oldUint8Array.set(newUint8Array);

// Update where the free space in the data array starts again
this.freeStart = currentDataStart;
Expand Down