β‘ Bolt: Optimize defragmentation and fix offset bug #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What:
Replaced manual byte-by-byte copy loops in
ShareableMap.defragmentandShareableArray.defragmentwithUint8Array.prototype.setusingsubarrayviews.Fixed a bug in
ShareableArray.defragmentwhereDATA_OBJECT_OFFSETwas incorrectly added twice to thecurrentDataStartpointer, causing gaps in the defragmented array.π― Why:
The manual copy loop was slow (~62ms for 10MB/256B blocks vs ~6ms with
set).The offset bug in
ShareableArraywasted 8 bytes of memory per item during defragmentation.π Impact:
ShareableArrayafter defragmentation by eliminating unnecessary gaps.π¬ Measurement:
Verified with a reproduction test that confirmed the offset bug fix (memory usage dropped from 872 to 840 bytes in test scenario).
Verified optimization with a standalone benchmark (not included in PR).
Verified full test suite passes.
PR created automatically by Jules for task 5877455073732309065 started by @pverscha