Deprecate DAVObject.name in favor of get_display_name() #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DAVObject.__init__ now accepts `name` parameter, stores in props cache
as {DAV:}displayname (no deprecation warning on construction)
- DAVObject.name is now a property that calls get_display_name() and
emits DeprecationWarning when accessed
- Calendar.__init__ passes name to parent (stored in props cache)
- Calendar.save() uses props cache directly instead of self.name
Migration path:
- Old: calendar.name → New: calendar.get_display_name()
- Old: Calendar(name="foo") → Still works, stores in props cache
Closes #128
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAVObject.__init__now acceptsnameparameter, stores in props cache as{DAV:}displayname(no deprecation warning on construction)DAVObject.nameis now a property that callsget_display_name()and emitsDeprecationWarningwhen accessedCalendar.__init__passes name to parent (stored in props cache)Calendar.save()uses props cache directly instead ofself.nameMigration path:
calendar.name→ New:calendar.get_display_name()Calendar(name="foo")→ Still works, stores in props cacheCloses #128