-
Notifications
You must be signed in to change notification settings - Fork 2
Feat: Menú dinámico con comportamiento estándard por teclado #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ctrl-alt-d
wants to merge
16
commits into
develop
Choose a base branch
from
accessiblenav
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the mechanism to copy the sponsors emails to using the 'mailto:' attribute, in order to launch an email client and write the email directly. A suggested 'subject' was included as well, to simplify the contact from possible sponsors.
<img width="1174" height="763" alt="Captura de pantalla 2026-01-21 a las 11 44 25" src="https://github.com/user-attachments/assets/bbc4376a-dd45-4a25-bf3f-10d385fba697" /> <img width="1183" height="753" alt="Captura de pantalla 2026-01-21 a las 11 44 45" src="https://github.com/user-attachments/assets/4c915364-e24d-4502-ac04-c2382e969e2b" /> --------- Co-authored-by: Alejandro Cabello Jiménez <alejandro@travelperk.com> Co-authored-by: Dani H <ctrl.alt.d@gmail.com>
# Closes #45 Co-authored-by: Ferran Jovell <ferran.jovell+github@gmail.com>
# Summary: - Add sponsor logos to the sponsors page (sponsors.astro) replacing text-only names - Create public/sponsors/ folder for storing company logo assets # Desktop: <img width="1264" height="973" alt="image" src="https://github.com/user-attachments/assets/a25784b0-515b-4724-82ef-c34788e92e5b" /> # Mobile: <img width="434" height="627" alt="image" src="https://github.com/user-attachments/assets/5e371ccb-944c-48d1-ac29-84909d58debd" />
# Summary - Fix horizontal page scroll on mobile for the sponsors page by adding overflow-x-hidden to the page wrapper - Make the pricing table's first column (Beneficios, category headers, row labels) sticky so they remain visible while scrolling horizontally - Change table from border-collapse to border-separate to ensure borders render correctly with sticky positioning https://github.com/user-attachments/assets/fe9a5a9d-7359-4813-9acd-7191e640454e
This PR implements Internationalization (i18n) for the PyConES 2026
website, specifically focusing on the Sponsors page and landing
components. It introduces support for English (en), Spanish (es), and
Catalan (ca).
Key Changes
- i18n Infrastructure: * Added translation files (.ts) for all
sponsor-related content (tiers, benefits, testimonials, and past
sponsors).
Implemented a middleware to handle automatic language detection based on
the user's browser settings (Accept-Language).
- Routing & Structure:
Refactored page structure to use dynamic routing: moved pages to
src/pages/[lang]/.
Updated astro.config.mjs to configure the i18n routing strategy.
- UI/UX Improvements:
Localized the landing page elements (Hero title, subtitle, and CTA
buttons).
Updated the Layout.astro to dynamically set the lang attribute in the
HTML tag for better accessibility and SEO.
- Technical Cleanup:
Centralized text constants to improve maintainability.
Refactored the main index and sponsors pages to consume translated
strings via a helper.
- Languages Added:
Spanish es
English en
Catalan ca
---------
Co-authored-by: dani herrera <ctrl.alt.d@gmail.com>
Co-authored-by: Francesc Arpí Roca <francescarpi@users.noreply.github.com>
Le da más humanidad. Antes: <img width="1203" height="700" alt="image" src="https://github.com/user-attachments/assets/9895037b-db04-4a00-bc88-c127359fbeb2" /> Después: <img width="1245" height="749" alt="image" src="https://github.com/user-attachments/assets/1f7bdf20-4e79-49d2-b3ec-ba8d22e9ad38" />
En esta PR, refactor: * Se sustituyen los valores hardcoded relacionados con la i18n por los valores de la configuración del proyecto. * Se quitan los strings traducibles del componente para llevarlos a la carpeta de traducciones.
…ve quotes image size and its placement (#61) # Summary - Add collaborator logos (EuroPython, PSF, Python España, UB) - Improve testimonials section visual design with decorative quote icons and green accent borders - Update sponsor translations (ca, en, es) # Desktop <img width="832" height="1296" alt="SCR-20260201-lvqo" src="https://github.com/user-attachments/assets/ae62314f-7515-45dd-8d25-f14b436c8913" /> # Mobile <img width="440" height="810" alt="image" src="https://github.com/user-attachments/assets/09011e44-acc6-4753-bcee-fbbbdb4ec911" /> <img width="444" height="817" alt="image" src="https://github.com/user-attachments/assets/1111a1d5-eefd-4384-8215-8c3e3a55b6ca" />
Este PR corrige el responsivo para la sección de seniority. Antes: <img width="446" height="340" alt="image" src="https://github.com/user-attachments/assets/0e0df782-98cf-4bc6-babb-945f814abc1f" /> Ahora: <img width="423" height="436" alt="image" src="https://github.com/user-attachments/assets/988aad6f-4b1c-4601-97ce-fb91998a3439" /> Fixes #60
itziarZG
approved these changes
Feb 2, 2026
Collaborator
itziarZG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine! great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menú dinámico con navegación accesible por teclado.
Keyboard behaviors: