-
Notifications
You must be signed in to change notification settings - Fork 801
parakeet portable mode works on cuda server #16674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16674
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Cancelled Jobs, 1 Unrelated FailureAs of commit 96d1e08 with merge base 3341474 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
It seems like this PR just makes the max audio length user settable. Its not clear to me why this specifically was impacting your ability to run with cuda acceleration. |
| parser.add_argument( | ||
| "--max-audio-sec", | ||
| type=int, | ||
| default=30, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it 600 seconds like before
The thing is we miscalculated the num of mel we need to use for export from 1000 to 100; therefore when I working on portable mode on cuda server it can not support it due to the input is too large for the pte |
Previously we hardcoded a wrong number of mel for model export, leading to tensor resize issue when we running parakeet portable mode on cuda server.
This PR makes the size of tensor used for model export decided by user-specific max length of audio.