Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jan 16, 2026

Previously we hardcoded a wrong number of mel for model export, leading to tensor resize issue when we running parakeet portable mode on cuda server.

This PR makes the size of tensor used for model export decided by user-specific max length of audio.

@Gasoonjia Gasoonjia requested a review from lucylq as a code owner January 16, 2026 22:55
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 16, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16674

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Cancelled Jobs, 1 Unrelated Failure

As of commit 96d1e08 with merge base 3341474 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Gasoonjia Gasoonjia changed the title cuda server works parakeet portable mode works on cuda server Jan 16, 2026
@Gasoonjia Gasoonjia marked this pull request as draft January 16, 2026 22:59
@Gasoonjia Gasoonjia marked this pull request as ready for review January 16, 2026 23:34
@JacobSzwejbka
Copy link
Contributor

It seems like this PR just makes the max audio length user settable. Its not clear to me why this specifically was impacting your ability to run with cuda acceleration.

parser.add_argument(
"--max-audio-sec",
type=int,
default=30,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it 600 seconds like before

@Gasoonjia
Copy link
Contributor Author

It seems like this PR just makes the max audio length user settable. Its not clear to me why this specifically was impacting your ability to run with cuda acceleration.

The thing is we miscalculated the num of mel we need to use for export from 1000 to 100; therefore when I working on portable mode on cuda server it can not support it due to the input is too large for the pte
not super sure why it can work on Mac (Claude said cpu PyTorch is not that strict so it can work but gpu PyTorch is stricter)
This pr makes the export file use the correct tensor for export, and make sure the miscalculation will not happen again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants