Normalize constant and buffer dim order in to_edge #16681
Draft
+163
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryComer
requested review from
JacobSzwejbka,
digantdesai and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16681
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 3d6c64a with merge base af69d08 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90898806. |
GregoryComer
changed the title
GregoryComer
changed the title
GregoryComer
added
the
release notes: exir
GregoryComer
force-pushed
the
export-D90898806
branch
2 times, most recently
from
35f560f to
a775bbc
Compare
Summary: Add a pass in to_edge to ensure all constant tensors have contiguous or channels-last dim order. Tensors with dim orders not present in this list get converted to contiguous. This solves a class of bugs related to strided constant tensors, such as the one causing pytorch#14644. As per discussion with Gasoonjia, exir already assumes that tensors have one of these two dim orders. Differential Revision: D90898806
GregoryComer
force-pushed
the
export-D90898806
branch
from
a775bbc to
3d6c64a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a pass in to_edge to ensure all constant tensors have contiguous or channels-last dim order. Tensors with dim orders not present in this list get converted to contiguous. This solves a class of bugs related to strided constant tensors, such as the one causing #14644.
As per discussion with @Gasoonjia, EXIR already assumes that tensors have one of these two dim orders.
Differential Revision: D90898806