Fix the "pending" state of RTCs, on Pi 5 and beyond #7198
+18
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating a report of the Pi 5 RTC not correctly advertising the alarm "pending" state - an indication that the alarm has fired and woken the host - appears to show that there are bugs in the Pi 5 RTC implementation, but also that it is broken for all RTCs.
These two patches fix the rtc-pi5 bug (a simple failure to populate the
pendingfield ofstruct rtc_wkalrm), but also modify the RTC framework such that the value read from the RTCs is made available to users ofrtc_read_alaram, including the code that provides the output from/proc/driver/rtc.See: raspberrypi/firmware#2011