Fix CLI import_submodules to work with pyenv #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sys.path.insert(0, os.getcwd()) to import_submodules() so that modules can be found when using pyenv or similar tools where Python binaries are stored outside the project directory. Fixes #682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #682 - Migrator CLI tool does not work properly when using pyenv virtualenv.
The
import_submodules()function now addsos.getcwd()tosys.pathbefore attempting to import the root module. This ensures that modules can be found when using pyenv or similar tools where Python binaries are stored outside the project directory.Changes
sys.path.insert(0, os.getcwd())at the beginning ofimport_submodules()inlegacy_migrator.pysys.path