Fix dep_updates for v1 recipes using python_min #5306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case reproduces the issue where the dep_updates migrator fails for v1 recipes when grayskull generates a recipe with `skip: match(python, ...)` but the feedstock's variant config only has `python_min` (not `python`). The test adds: - dominodatalab feedstock as a git submodule (pinned to v1.4.7) - Test case that validates version update from 1.4.7 to 2.0.0 - New `assert_pr_body_not_contains` helper method to check PR body - Assertion that the PR body doesn't contain the dep_updates error message The test currently fails, demonstrating the bug where rattler-build skips all variants when the `python` variable is not in the variant config. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This test reproduces the issue where get_grayskull_comparison fails for v1 recipes when grayskull generates `skip: match(python, "<3.10")` but the variant config only has `python_min` (not `python`). The test is marked as xfail since it currently fails - rattler-build skips all variants when the `python` variable is not set in the variant config. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The xfail marker was causing pytest to consider the failing test as "passing" (expected failure). Removing it ensures the test actually fails in CI until the bug is fixed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace `match(python, ...)` with `match(python_min, ...)` in grayskull-generated v1 recipes. This fixes the dep_updates migrator for feedstocks using CFEP-25's python_min variable. Grayskull generates skip conditions like `skip: match(python, "<3.10")` but v1 recipe variant configs only define `python_min`, not `python`. This caused rattler-build to skip all variants with: "Failed to render recipe YAML! No output recipes found!" See: conda/grayskull#574 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
janjagusch
changed the title
- Add mock endpoint for version-specific PyPI API (/pypi/dominodatalab/2.0.0/json) - Include 'urls' field in main PyPI endpoint for grayskull sdist discovery - Add spdx.org/* to transparent URLs (grayskull license discovery) - Store full PyPI metadata response for reproducible testing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
janjagusch
force-pushed
the
add-dominodatalab-integration-test
branch
from
12a2004 to
09ca7cc
Compare
Add documentation to help Claude Code understand the codebase structure, common commands, and integration test setup. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
@wolfv rattler build should define python, right? Is this an issue somewhere in rattler-build or smithy maybe? |
…egration-test # Conflicts: # .gitmodules
ytausch
approved these changes
Jan 19, 2026
Contributor
There was a problem hiding this comment.
Can you name this file AGENTS.md and symlink from CLAUDE.md to it? This way, other agents (such as Copilot and Cursor) also take this file into account.
(You might also need to remove all references to Claude Code in particular)
|
|
||
| ### Development Setup | ||
| ```bash | ||
| # Using environment.yml (recommended for development) |
Contributor
There was a problem hiding this comment.
Is this true? I think we should also recommend the lockfile for development
| conda env create -f environment.yml | ||
|
|
||
| # Or using the production lockfile | ||
| wget https://raw.githubusercontent.com/regro/cf-scripts/main/conda-lock.yml |
Contributor
There was a problem hiding this comment.
It should already be there locally, no need to wget
| 2. `prepare(helper)`: Sets up test state (e.g., overwrites feedstock contents) | ||
| 3. `validate(helper)`: Asserts expected outcomes (e.g., PR was created with correct changes) | ||
|
|
||
| Current test feedstocks: `pydantic`, `polars`, `fastapi`, `zizmor`, `conda-forge-pinning`. |
Contributor
There was a problem hiding this comment.
Leave out this list, it will not be maintained
beckermr
requested changes
Jan 19, 2026
| # Grayskull generates `match(python, ...)` for noarch recipes, but v1 recipes | ||
| # use `python_min` in their variant configs (CFEP-25). Replace to make the | ||
| # recipe renderable. See: https://github.com/conda/grayskull/issues/574 | ||
| recipe_str = recipe_str.replace("match(python,", "match(python_min,") |
Contributor
There was a problem hiding this comment.
This filter is rather broad and I am concerned it might sweep up other parts of the recipe with this syntax. I suggested we write a more targeted edit that ensures the change is in a noarch: python recipe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the dep_updates migrator failing for v1 recipes that use
python_min(CFEP-25).Root cause: Grayskull generates
skip: match(python, "<3.10")for noarch recipes, but v1 recipe variant configs only definepython_min, notpython. When rattler-build tries to render the recipe, all variants are skipped becausepythonis undefined.Fix: Replace
match(python,withmatch(python_min,in grayskull-generated v1 recipes before rendering.Changes
_make_grayskull_recipe_v1to replacematch(python,withmatch(python_min,test_get_grayskull_comparison_v1_python_min_mismatchassert_pr_body_not_containshelper method for integration testsTest Evidence
Successful version update PR created by the bot during integration testing:
janjagusch-conda-forge-bot-staging/dominodatalab-feedstock#28
Related
python_minconda/grayskull#574Closes #5123
Unrelated addition: This PR also adds
CLAUDE.mdto provide guidance for Claude Code when working with this repository.🤖 Generated with Claude Code