Skip to content

Conversation

@cfvescovo
Copy link
Member

  • Bump ego-tree from 0.10.0 to 0.11.0
  • Bump html5ever from 0.36.0 to 0.37.1
  • Bump tendril from 0.4.3 to 0.5.0 (required by html5ever 0.37.1)
  • Implement clone_subtree() method for TreeSink trait

- Bump ego-tree from 0.10.0 to 0.11.0
- Bump html5ever from 0.36.0 to 0.37.1
- Bump tendril from 0.4.3 to 0.5.0 (required by html5ever 0.37.1)
- Implement clone_subtree() method for TreeSink trait
Copilot AI review requested due to automatic review settings January 23, 2026 21:00
@cfvescovo cfvescovo merged commit 60cd9e7 into master Jan 23, 2026
9 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the HTML parsing stack (ego-tree, html5ever, tendril) and updates the HtmlTreeSink to implement the new TreeSink::clone_subtree API, along with minor logging modernizations.

Changes:

  • Bump ego-tree to 0.11.0, html5ever to 0.37.1, and tendril to 0.5.0 to keep dependencies current and compatible.
  • Implement TreeSink::clone_subtree for HtmlTreeSink by delegating to ego_tree’s clone_subtree and returning the new node’s NodeId.
  • Modernize error printing in scraper/src/main.rs to use captured format arguments.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
scraper/src/main.rs Switches eprintln! calls to captured-format syntax, preserving behavior while updating style.
scraper/src/html/tree_sink.rs Adds a clone_subtree implementation that clones a subtree via ego_tree and returns the cloned root’s handle, matching the updated TreeSink trait.
scraper/Cargo.toml Updates direct dependency versions for ego-tree, html5ever, and tendril to the new releases.
Cargo.lock Regenerates lockfile to reflect updated crate versions and transitive dependency changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants